From c5c97b07b5caa5ec262c2afae17af216caba972f Mon Sep 17 00:00:00 2001 From: Jack Franklin Date: Tue, 28 Apr 2020 17:45:55 +0100 Subject: [PATCH] chore: remove DOMWorld definition from externs.d.ts (#5767) Missed in the initial work to migrate DOMWorld to TypeScript. --- src/ExecutionContext.ts | 5 +++-- src/externs.d.ts | 2 -- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/ExecutionContext.ts b/src/ExecutionContext.ts index 021f6504018fe..75a6e19e07c07 100644 --- a/src/ExecutionContext.ts +++ b/src/ExecutionContext.ts @@ -17,16 +17,17 @@ import {helper, assert} from './helper'; import {createJSHandle, JSHandle, ElementHandle} from './JSHandle'; import {CDPSession} from './Connection'; +import {DOMWorld} from './DOMWorld'; export const EVALUATION_SCRIPT_URL = '__puppeteer_evaluation_script__'; const SOURCE_URL_REGEX = /^[\040\t]*\/\/[@#] sourceURL=\s*(\S*?)\s*$/m; export class ExecutionContext { _client: CDPSession; - _world: Puppeteer.DOMWorld; + _world: DOMWorld; _contextId: number; - constructor(client: CDPSession, contextPayload: Protocol.Runtime.ExecutionContextDescription, world: Puppeteer.DOMWorld) { + constructor(client: CDPSession, contextPayload: Protocol.Runtime.ExecutionContextDescription, world: DOMWorld) { this._client = client; this._world = world; this._contextId = contextPayload.id; diff --git a/src/externs.d.ts b/src/externs.d.ts index 171fa23ffff85..390967abec9df 100644 --- a/src/externs.d.ts +++ b/src/externs.d.ts @@ -1,7 +1,6 @@ import {Target as RealTarget} from './Target.js'; import {Page as RealPage} from './Page.js'; import {Frame as RealFrame, FrameManager as RealFrameManager} from './FrameManager.js'; -import {DOMWorld as RealDOMWorld} from './DOMWorld.js'; import { NetworkManager as RealNetworkManager, Request as RealRequest, Response as RealResponse } from './NetworkManager.js'; import * as child_process from 'child_process'; declare global { @@ -10,7 +9,6 @@ declare global { export class Frame extends RealFrame {} export class FrameManager extends RealFrameManager {} export class NetworkManager extends RealNetworkManager {} - export class DOMWorld extends RealDOMWorld {} export class Page extends RealPage { } export class Response extends RealResponse { } export class Request extends RealRequest { }