refactor(firefox): introduce FrameManager (#3964)

Split out frame management from Page into FrameManager. FrameManager will keep track of page's frames and DOMWorlds.
puppeteer · Feb 9, 2019 · c64e02e · c64e02e
1 parent 2a7ed1a
commit c64e02e
Show file tree

Hide file tree

Showing 5 changed files with 783 additions and 734 deletions.
diff --git a/experimental/puppeteer-firefox/lib/Events.js b/experimental/puppeteer-firefox/lib/Events.js
@@ -24,6 +24,13 @@ const Events = {
   Connection: {
     Disconnected: Symbol('Events.Connection.Disconnected'),
   },
+
+  FrameManager: {
+    Load: Symbol('Events.FrameManager.Load'),
+    DOMContentLoaded: Symbol('Events.FrameManager.DOMContentLoaded'),
+    FrameAttached: Symbol('Events.FrameManager.FrameAttached'),
+    FrameDetached: Symbol('Events.FrameManager.FrameDetached'),
+  }
 };
 
 module.exports = {Events};