fix: use different test names for browser specific tests in launcher.…

…spec.ts (#8250)
puppeteer · Apr 20, 2022 · c6cf1a9 · c6cf1a9
1 parent 9a9ec8f
commit c6cf1a9
Showing 1 changed file with 40 additions and 35 deletions.
diff --git a/test/launcher.spec.ts b/test/launcher.spec.ts
@@ -404,44 +404,49 @@ describe('Launcher specs', function () {
         await page.close();
         await browser.close();
       });
-      itChromeOnly('should filter out ignored default arguments', async () => {
-        const { defaultBrowserOptions, puppeteer } = getTestState();
-        // Make sure we launch with `--enable-automation` by default.
-        const defaultArgs = puppeteer.defaultArgs();
-        const browser = await puppeteer.launch(
-          Object.assign({}, defaultBrowserOptions, {
-            // Ignore first and third default argument.
-            ignoreDefaultArgs: [defaultArgs[0], defaultArgs[2]],
-          })
-        );
-        const spawnargs = browser.process().spawnargs;
-        if (!spawnargs) {
-          throw new Error('spawnargs not present');
+      itChromeOnly(
+        'should filter out ignored default arguments in Chrome',
+        async () => {
+          const { defaultBrowserOptions, puppeteer } = getTestState();
+          // Make sure we launch with `--enable-automation` by default.
+          const defaultArgs = puppeteer.defaultArgs();
+          const browser = await puppeteer.launch(
+            Object.assign({}, defaultBrowserOptions, {
+              // Ignore first and third default argument.
+              ignoreDefaultArgs: [defaultArgs[0], defaultArgs[2]],
+            })
+          );
+          const spawnargs = browser.process().spawnargs;
+          if (!spawnargs) {
+            throw new Error('spawnargs not present');
+          }
+          expect(spawnargs.indexOf(defaultArgs[0])).toBe(-1);
+          expect(spawnargs.indexOf(defaultArgs[1])).not.toBe(-1);
+          expect(spawnargs.indexOf(defaultArgs[2])).toBe(-1);
+          await browser.close();
         }
-        expect(spawnargs.indexOf(defaultArgs[0])).toBe(-1);
-        expect(spawnargs.indexOf(defaultArgs[1])).not.toBe(-1);
-        expect(spawnargs.indexOf(defaultArgs[2])).toBe(-1);
-        await browser.close();
-      });
-      itFirefoxOnly('should filter out ignored default arguments', async () => {
-        const { defaultBrowserOptions, puppeteer } = getTestState();
+      );
+      itFirefoxOnly(
+        'should filter out ignored default argument in Firefox',
+        async () => {
+          const { defaultBrowserOptions, puppeteer } = getTestState();
 
-        const defaultArgs = puppeteer.defaultArgs();
-        const browser = await puppeteer.launch(
-          Object.assign({}, defaultBrowserOptions, {
-            // Only the first argument is fixed, others are optional.
-            ignoreDefaultArgs: [defaultArgs[0]],
-          })
-        );
-        const spawnargs = browser.process().spawnargs;
-        if (!spawnargs) {
-          throw new Error('spawnargs not present');
+          const defaultArgs = puppeteer.defaultArgs();
+          const browser = await puppeteer.launch(
+            Object.assign({}, defaultBrowserOptions, {
+              // Only the first argument is fixed, others are optional.
+              ignoreDefaultArgs: [defaultArgs[0]],
+            })
+          );
+          const spawnargs = browser.process().spawnargs;
+          if (!spawnargs) {
+            throw new Error('spawnargs not present');
+          }
+          expect(spawnargs.indexOf(defaultArgs[0])).toBe(-1);
+          expect(spawnargs.indexOf(defaultArgs[1])).not.toBe(-1);
+          await browser.close();
         }
-        expect(spawnargs.indexOf(defaultArgs[0])).toBe(-1);
-        expect(spawnargs.indexOf(defaultArgs[1])).not.toBe(-1);
-        await browser.close();
-      });
-
+      );
       it('should have default URL when launching browser', async function () {
         const { defaultBrowserOptions, puppeteer } = getTestState();
         const browser = await puppeteer.launch(defaultBrowserOptions);