Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
feat: add experimental client to HTTPRequest (#8556)
  • Loading branch information
jrandolf committed Jun 23, 2022
1 parent ebcb8a2 commit ec79f3a
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions src/common/HTTPRequest.ts
Expand Up @@ -157,6 +157,15 @@ export class HTTPRequest {
#interceptHandlers: Array<() => void | PromiseLike<any>>;
#initiator: Protocol.Network.Initiator;

/**
* Warning! Using this client can break Puppeteer. Use with caution.
*
* @experimental
*/
get client(): CDPSession {
return this.#client;
}

/**
* @internal
*/
Expand Down

1 comment on commit ec79f3a

@kboicourt
Copy link

@kboicourt kboicourt commented on ec79f3a Sep 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new "experimental" get client() call is causing breaking errors when opening a new page object in a puppeteer script. The issue appears to be propagated all the way through to the current version as well (17.0.0).

Please sign in to comment.