From f622c30c0f975e0d62336e8e6d1516c605de5049 Mon Sep 17 00:00:00 2001 From: Johan Bay Date: Tue, 8 Sep 2020 09:15:52 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Mathias Bynens --- CONTRIBUTING.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index f09eebbb3d40d..f49a7eb4b3e8f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -274,12 +274,12 @@ See [Debugging Tips](README.md#debugging-tips) in the readme. The following steps are needed to update the Chromium version. 1. Find a suitable Chromium revision - Not all revisions has builds for all platforms, so we need to find one that does. + Not all revisions have builds for all platforms, so we need to find one that does. To do so, run `utils/check_availability.js -rb` to find the latest suitable beta Chromium revision (see `utils/check_availability.js -help` for more options). -2. Update `src/revisions.ts` with the found revision number. -3. Run `npm run ensure-correct-devtools-protocol-revision`. - If it fails, update `package.json` with the expected `devtools-protoocol` version. -4. Run `npm run tsc` and `npm install` and ensure that all tests pass. +1. Update `src/revisions.ts` with the found revision number. +1. Run `npm run ensure-correct-devtools-protocol-revision`. + If it fails, update `package.json` with the expected `devtools-protocol` version. +1. Run `npm run tsc` and `npm install` and ensure that all tests pass. If a test fails, bisect the upstream cause of the failure, and either update the test expectations accordingly (if it was an intended change) or work around the changes in Puppeteer (if it’s not desirable to change Puppeteer’s observable behavior). ## Releasing to npm