Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Integrate chrome-headless-shell binaries #10736

Closed
1 of 2 tasks
OrKoN opened this issue Aug 16, 2023 · 3 comments
Closed
1 of 2 tasks

[Feature]: Integrate chrome-headless-shell binaries #10736

OrKoN opened this issue Aug 16, 2023 · 3 comments
Labels

Comments

@OrKoN
Copy link
Collaborator

OrKoN commented Aug 16, 2023

Feature description

See https://googlechromelabs.github.io/chrome-for-testing/

  • Support in @puppeteer/browsers
  • Support in puppeteer

In Puppeteer, we probably want to download the chrome-headless-shell binary by default as well as launch it when the user configures the headless: true.

@OrKoN OrKoN added the feature label Aug 16, 2023
@OrKoN
Copy link
Collaborator Author

OrKoN commented Aug 16, 2023

cc @mathiasbynens

@Sparticuz
Copy link
Contributor

I'm working on getting chrome-headless-shell working on the upcoming amazon linux 2023 lambda containers, so right now I'm working on getting it running inside a docker image (amazonlinux:2023), but I'm getting an error running it after downloading in @puppeteer/browsers. Looking up that error brings me to https://chromium.googlesource.com/chromium/src/base/+/master/i18n/icu_util.cc#240, which leads me to a private issue https://bugs.chromium.org/p/chromium/issues/detail?id=445616

Any ideas?

sh-5.2# npx @puppeteer/browsers install chrome-headless-shell    
Downloading chrome-headless-shell r120.0.6073.0 - 76 MB [====================] 100% 0.0s 
chrome-headless-shell@120.0.6073.0 /root/chrome-headless-shell/linux-120.0.6073.0/chrome-headless-shell-linux64/chrome-headless-shell
sh-5.2# cd chrome-headless-shell/linux-120.0.6073.0/chrome-headless-shell-linux64/
sh-5.2# ls 
ABOUT  chrome-headless-shell
sh-5.2# ./chrome-headless-shell --headless --remote-debugging-port=9222 https://chromium.org
[1018/195318.101023:ERROR:icu_util.cc(240)] Invalid file descriptor to ICU data received.
Trace/breakpoint trap

@Lightning00Blade
Copy link
Collaborator

Closing as completed in #11754,
@Sparticuz if the issue is still present please open a separate issue for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants