New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement screencasting #11084
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrandolf
force-pushed
the
jrandolf/screenshots
branch
from
October 6, 2023 03:35
2814fcc
to
aa6aef6
Compare
jrandolf
force-pushed
the
jrandolf/screenshots
branch
2 times, most recently
from
October 6, 2023 03:39
d0d3b9f
to
bffa674
Compare
jrandolf
force-pushed
the
jrandolf/screenshots
branch
3 times, most recently
from
October 6, 2023 05:49
a8722e5
to
d516ae4
Compare
jrandolf
force-pushed
the
jrandolf/screenshots
branch
from
October 6, 2023 06:13
d516ae4
to
9e0ba59
Compare
@jrandolf could you please rebase? |
jrandolf
force-pushed
the
jrandolf/screenshots
branch
5 times, most recently
from
October 6, 2023 06:45
ab2c733
to
b204984
Compare
OrKoN
reviewed
Oct 6, 2023
OrKoN
reviewed
Oct 6, 2023
OrKoN
reviewed
Oct 6, 2023
jrandolf
force-pushed
the
jrandolf/screenshots
branch
5 times, most recently
from
October 6, 2023 08:15
2ae9306
to
2cc13fe
Compare
OrKoN
reviewed
Oct 6, 2023
jrandolf
force-pushed
the
jrandolf/screenshots
branch
2 times, most recently
from
October 6, 2023 08:27
87c6390
to
33f0d4e
Compare
jrandolf
force-pushed
the
jrandolf/screenshots
branch
from
October 6, 2023 08:39
33f0d4e
to
fba921b
Compare
OrKoN
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jrandolf
force-pushed
the
jrandolf/screenshots
branch
from
October 6, 2023 08:42
fba921b
to
fa5aa40
Compare
jrandolf
force-pushed
the
jrandolf/screenshots
branch
4 times, most recently
from
October 6, 2023 09:09
69de1ab
to
8e0c2ce
Compare
jrandolf
force-pushed
the
jrandolf/screenshots
branch
from
October 6, 2023 14:34
8e0c2ce
to
1c5ee03
Compare
Merged
campersau
reviewed
Oct 20, 2023
} = roundRectangle(normalizeRectangle(options.crop)); | ||
if (x < 0 || y < 0) { | ||
throw new Error( | ||
`\`crop.x\` and \`crop.x\` must be greater than or equal to 0.` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the scond one should be crop.y
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Screencasting is a new, experimental feature that allows users to record their flows as that run!
Example
You can also stream the recorder to somewhere else!
Options
For now, we have three options:
crop
- Specifies the region of the viewport to crop.scale
- Scales the output video. For example,0.5
will shrink the width and height of the output video by half.2
will double the width and height of the output video.path
- Specifies a.webm
file path to save the recording to.speed
- Specifies the speed to record at. For example,0.5
will slowdown the video by 50%.2
will double the speed of the output video.Fixed: #478