fix: add InlineTextBox as a non-element a11y role #11142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service bot
pushed a commit
to ChromeDevTools/devtools-frontend
that referenced
this pull request
Oct 12, 2023
Chromium pin updated to 120.0.6061.0 Roll created at https://cr-buildbucket.appspot.com/build/8767442795318961393 DISABLE_THIRD_PARTY_CHECK=hotfix Puppeteer to unblock Chrome roll as making a Puppeteer release will take some time (upstream fix puppeteer/puppeteer#11142) Bug: chromium:1492122 Change-Id: I427df7f777cdf24b50e3e4532d9230fa0a04ae84 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4934291 Reviewed-by: Simon Zünd <szuend@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
OrKoN
force-pushed
the
orkon/fix-a11y-role-check
branch
from
5a1d6b2
to
a0a4dc1
Compare
Lightning00Blade
approved these changes
Oct 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes that caused https://crbug.com/1492122 seem to enable InlineTextBox to be returned as a node for certain elements referencing a TextNode instead of an HTML element. We should filter those out in the same way as StaticText.