Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update TextQuerySelector cache on subtree update #11200

Merged
merged 1 commit into from Oct 19, 2023

Conversation

Donnatello
Copy link
Contributor

@google-cla
Copy link

google-cla bot commented Oct 19, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Oct 19, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@OrKoN OrKoN requested a review from jrandolf October 19, 2023 06:56
@Lightning00Blade Lightning00Blade changed the title Fix updating textContentCache in TextQuerySelector fix: updating textContentCache in TextQuerySelector Oct 19, 2023
@jrandolf jrandolf changed the title fix: updating textContentCache in TextQuerySelector fix: update TextQuerySelector cache on subtree update Oct 19, 2023
@jrandolf jrandolf force-pushed the fix/updating-textContentCache branch from 32bbb5d to b9c5c5e Compare October 19, 2023 09:53
@jrandolf jrandolf merged commit 4206e76 into puppeteer:main Oct 19, 2023
44 of 47 checks passed
@release-please release-please bot mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants