New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove CDP-specific preferences from defaults for Firefox #11477
Conversation
ed55372
to
f358a4e
Compare
After a discussion with @OrKoN yesterday and some additional investigation on our side I found the problem that is causing some tests around out-of-process iframes to fail. I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1867667 and we will work on it shortly. We should wait for it to be fixed on Nightly and then retrigger the tests on this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise this looks all fine. Lets see what happens with test results once we have the contentWindow
issue fixed.
3 out of 5 failures are fixed now in the recent version of Firefox Nightly. We took a brief look at the remaining two failing tests and they are related to a click on an element that is within a cross-origin iframe. Hereby the click doesn't happen with the iframe's browsing context reference but the one for the top-level browsing context. @OrKoN and @sadym-chromium I assume that this is expected? If yes, does it block landing these pref changes? |
@whimboo I believe this behavior is expected from Puppeteer's perspective. It does not work in Firefox only for now or is our expectation not spec-compliant? |
bc390c0
to
cf32f30
Compare
We are having a project early next year to add support for dispatching events from the parent process asynchronously. Until then the event needs to be submitted from the same browsing context. Maybe we keep the site isolation feature off for now to keep it working, or turn it off by default and file an issue with details for a workaround for now in case cross-origin iframes are involved. What would be your option? |
3d7489a
to
4da9de2
Compare
Let's keep it working for now by turning off the isolation feature. |
1491a2f
to
38636c1
Compare
38636c1
to
3122ced
Compare
Closes #11474