feat!: remove PUPPETEER_DOWNLOAD_PATH in favor of PUPPETEER_CACHE_DIR #11605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lightning00Blade
approved these changes
Jan 2, 2024
|
Let's wait, yes. |
OrKoN
force-pushed
the
orkon/remove-PUPPETEER_DOWNLOAD_PATH
branch
from
3d2cf84
to
7d24d59
Compare
OrKoN
force-pushed
the
orkon/remove-PUPPETEER_DOWNLOAD_PATH
branch
from
7d24d59
to
fcaaa20
Compare
OrKoN
force-pushed
the
orkon/remove-PUPPETEER_DOWNLOAD_PATH
branch
from
fcaaa20
to
2bf0703
Compare
This was referenced Feb 2, 2024
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To migrate: use PUPPETEER_CACHE_DIR/cacheDirectory instead of PUPPETEER_DOWNLOAD_PATH/downloadPath.
Closes #10164