feat: support local aliases when launching a browser #11947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/support-launch-aliases
branch
3 times, most recently
from
15c77f8
to
16f0301
Compare
This comment was marked as resolved.
This comment was marked as resolved.
OrKoN
force-pushed
the
orkon/support-launch-aliases
branch
3 times, most recently
from
07e7404
to
a29dd2c
Compare
OrKoN
changed the title
OrKoN
force-pushed
the
orkon/support-launch-aliases
branch
2 times, most recently
from
8886960
to
6471e52
Compare
OrKoN
commented
Feb 20, 2024
OrKoN
force-pushed
the
orkon/support-launch-aliases
branch
2 times, most recently
from
674894c
to
9582dba
Compare
packages/browsers/src/install.ts
Outdated
| if (options.buildIdAlias) { | ||
| const metadata = installedBrowser.readMetadata(); | ||
| metadata.aliases[options.buildIdAlias] = options.buildId; | ||
| metadata.aliases['latest'] = options.buildId; |
There was a problem hiding this comment.
Suggested change
| metadata.aliases['latest'] = options.buildId; |
Lightning00Blade
approved these changes
Feb 20, 2024
With this PR, @puppeteer/browsers starts maintaining a local mapping from an alias to the locally installed version. This allows using aliases such as `canary`/`latest` when launching the browser. Note that the launch command would only consult metadata files and won't attempt to re-check aliases by contacting the server.
OrKoN
force-pushed
the
orkon/support-launch-aliases
branch
from
9582dba
to
2d0e0d6
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, @puppeteer/browsers starts maintaining a local mapping from an alias to the locally installed browser version. This allows using aliases such as
canary/devwhen launching the browser. Note thatlatestfor launch will resolve to the latest version found in the local metadata file.Note that the launch command would only consult metadata files and won't attempt to re-check aliases by contacting the server.
Closes #11140
Closes #11781