feat: implement ElementHandle.uploadFile for WebDriver BiDi #11963
+105
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrandolf
force-pushed
the
jrandolf/set-files
branch
from
86af080
to
3edb639
Compare
OrKoN
reviewed
Feb 21, 2024
|
@jrandolf have you added WPT tests already? |
OrKoN
reviewed
Feb 21, 2024
There was a problem hiding this comment.
Let's also update https://pptr.dev/webdriver-bidi and move uploadFile from unsupported to supported
|
@jrandolf making as |
Lightning00Blade
changed the title
jrandolf
force-pushed
the
jrandolf/set-files
branch
3 times, most recently
from
32943f2
to
4a88094
Compare
I'll add this in a separate docs PR. We have more features that we support. |
jrandolf
force-pushed
the
jrandolf/set-files
branch
from
4a88094
to
96ae865
Compare
jrandolf
force-pushed
the
jrandolf/set-files
branch
2 times, most recently
from
917ec4f
to
8a9f9d9
Compare
OrKoN
changed the title
OrKoN
reviewed
Feb 26, 2024
Please include it in this PR so that it is releasable. |
jrandolf
force-pushed
the
jrandolf/set-files
branch
from
8a9f9d9
to
bd6d66d
Compare
jrandolf
force-pushed
the
jrandolf/set-files
branch
from
bd6d66d
to
538a8bc
Compare
OrKoN
approved these changes
Feb 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.