Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webdriver): wait for response if the response has not completed once navigation has finished #12018

Merged
merged 1 commit into from Feb 29, 2024

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Feb 28, 2024

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1882454

The windows failure is unrelated #12021

@OrKoN OrKoN changed the title test: wait for response fix: wait for response if the response has not completed once loading has finished Feb 28, 2024
@OrKoN OrKoN changed the title fix: wait for response if the response has not completed once loading has finished fix(webdriver): wait for response if the response has not completed once loading has finished Feb 28, 2024
@OrKoN OrKoN force-pushed the orkon/wait-for-nav branch 2 times, most recently from d25c67c to 931604a Compare February 28, 2024 18:27
@OrKoN OrKoN changed the title fix(webdriver): wait for response if the response has not completed once loading has finished fix(webdriver): wait for response if the response has not completed once navigation has finished Feb 28, 2024
@OrKoN OrKoN added the full-ci label Feb 28, 2024
@OrKoN OrKoN marked this pull request as ready for review February 29, 2024 06:52
Copy link
Collaborator

@Lightning00Blade Lightning00Blade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + comment

@OrKoN OrKoN merged commit 6d8831a into main Feb 29, 2024
62 checks passed
@OrKoN OrKoN deleted the orkon/wait-for-nav branch February 29, 2024 10:11
@release-please release-please bot mentioned this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants