feat(webdriver): support Page.deleteCookie() for WebDriver BiDi
#12031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadym-chromium
force-pushed
the
sadym/delete-cookie
branch
from
ba6b22d
to
64b7469
Compare
Let's add a test to also understand the cdp behavior better. |
OrKoN
reviewed
Feb 29, 2024
OrKoN
reviewed
Feb 29, 2024
sadym-chromium
force-pushed
the
sadym/delete-cookie
branch
from
2d454b9
to
6b46913
Compare
sadym-chromium
commented
Mar 4, 2024
Comment on lines
-562
to
-564
| // TODO: delete cookie before setting them. | ||
| // await this.deleteCookie(bidiCookie); | ||
|
|
There was a problem hiding this comment.
The scope of set and deleted cookie can be different, so deleting can cause some unwilling side effects. Example: a cookie is set for a specific path, but removed from the whole domain.
sadym-chromium
force-pushed
the
sadym/delete-cookie
branch
2 times, most recently
from
4c2d036
to
0304512
Compare
sadym-chromium
commented
Mar 4, 2024
sadym-chromium
force-pushed
the
sadym/delete-cookie
branch
from
31ef7c7
to
7244abc
Compare
This reverts commit 201e8a6.
sadym-chromium
force-pushed
the
sadym/delete-cookie
branch
from
7244abc
to
e33ee32
Compare
OrKoN
changed the title
Page.deleteCookie()Page.deleteCookie() for WebDriver BiDi
OrKoN
reviewed
Mar 4, 2024
OrKoN
reviewed
Mar 4, 2024
OrKoN
reviewed
Mar 4, 2024
sadym-chromium
force-pushed
the
sadym/delete-cookie
branch
from
36c75c1
to
fdac75a
Compare
OrKoN
approved these changes
Mar 4, 2024
sadym-chromium
force-pushed
the
sadym/delete-cookie
branch
from
fdac75a
to
4fdddff
Compare
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
Page.deleteCookie()via BiDistorage.deleteCookies.