Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Instructions can be improved/corrected #12324

Open
thdoan opened this issue Apr 25, 2024 · 2 comments
Open

[Bug]: Instructions can be improved/corrected #12324

thdoan opened this issue Apr 25, 2024 · 2 comments

Comments

@thdoan
Copy link

thdoan commented Apr 25, 2024

Minimal, reproducible example

A couple issues with the README.md...

1. For people who arrive at https://www.npmjs.com/package/puppeteer-core, following the instructions there will not work:


import puppeteer from 'puppeteer';

The documentation needs to point out that for puppeteer-core, the correct import is as follows:

import puppeteer from 'puppeteer-core';
  1. This actually won't work in reality:
await page.type('.devsite-search-field', 'automate beyond recorder');

It's missing the command to press the Enter key in order to perform the search:

await page.keyboard.press('Enter');


### Error string

N/A

### Bug behavior

- [ ] Flaky
- [ ] PDF

### Background

_No response_

### Expectation

N/A

### Reality

N/A

### Puppeteer configuration file (if used)

_No response_

### Puppeteer version

22.7.0

### Node version

18.18.0

### Package manager

npm

### Package manager version

9.8.1

### Operating system

Windows

This comment was marked as off-topic.

@thdoan
Copy link
Author

thdoan commented Apr 25, 2024

There's no issue to reproduce, this was only to improve the instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants