Support OOPIF #2548

aslushnikov · 2018-05-15T07:03:25Z

Out-of-process iframes are here now and have to be supported.

For the following HTML served from localhost, pptr fails to report the frame:

<h1>Hello world</h1>
<script>
  const frame = document.createElement('iframe')
  frame.setAttribute('name', 'bob')
  frame.setAttribute('src', 'https://google.com')
  document.body.appendChild(frame)
</script>

Original example: https://github.com/achingbrain/puppeteer-frames
Reported here: #1140 (comment)

The text was updated successfully, but these errors were encountered:

achingbrain · 2018-05-15T08:31:14Z

It doesn't even need any JavaScript on the page, plain HTML also fails in the same way:

<!DOCTYPE html>
<html>
  <head>
    <title>Where is my iframe?</title>
  </head>
  <body>
    <h1>Hello world</h1>
    <iframe name="bob" src="https://google.com"></iframe>
  </body>
</html>

aslushnikov · 2018-05-18T02:43:20Z

While we're figuring this out, a workaround is to run with --disable-features=site-per-process flag:

const browser = await puppeteer.launch({                                                                                                                                                                                                                                                            
  args: ['--disable-features=site-per-process'],                                                                                                                                                                                                                                                    
  headless: false                                                                                                                                                                                                                                                                                   
}) ;

tomholub · 2018-05-18T17:23:47Z

Unfortunately --disable-features=site-per-process does not help for extension frames on standard domains. Still missing. Tested with bundle from #2506

aslushnikov · 2018-05-31T01:23:54Z

@tomholub indeed, thanks for pointing out. It turned out extension isolation is hard-coded in chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc.

This patch disables OOPIF by default. **NOTE**: this is a temporary bandaid for the time we're crafting the full-fledged support for site isolation over DevTools protocol. References puppeteer#2548.

This patch disables OOPIF by default. **NOTE**: this is a temporary bandaid for the time we're crafting the full-fledged support for site isolation over DevTools protocol. References #2548.

aslushnikov · 2018-07-04T23:52:31Z

For the record: puppeteer v1.5.0 disables out-of-process iframes by default (see #2661). This, however, doesn't apply to extension iframes - these still operate out-of-process.

Swordyjohn · 2018-08-16T19:06:32Z

Is there a time frame for OOPIF support?

aslushnikov · 2018-08-17T06:17:15Z

@Swordyjohn no good eta; is this pressing you in any way?

Swordyjohn · 2018-08-17T13:37:46Z

@aslushnikov we are attempting to use Puppeteer for scraping a site with strong content security in a business setting (I'm an RPA in background screening) and we have had more success than other methods but we cannot access reCaptcha src info when served in order to export it to a click farm due to the OOPIF so we will probably try different automation frameworks.

tomholub · 2018-08-19T02:11:31Z

It's pressing us too - cannot test extension frames inside non extension tabs.

…

On Fri, 17 Aug 2018, 20:38 Swordyjohn, ***@***.***> wrote: @aslushnikov <https://github.com/aslushnikov> we are attempting to use Puppeteer for scraping a site with strong content security in a business setting (I'm an RPA in background screening) and we have had more success than other methods but we cannot access reCaptcha src info when served in order to export it to a click farm due to the OOPIF so we may need to explore other methods. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2548 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGA8kVHsMCuA9DAiofNCudL1Ta-WLT-wks5uRsdbgaJpZM4T-_qM> .

Banou26 · 2019-01-16T16:53:34Z

Any updates on this ? I really need OOPIF.
Any way i can help on this ?

defr0std · 2019-02-26T07:59:14Z

Not sure if it solves a problem with extensions, but here is what seems to be the proper way to work with out-of-process iframes.
https://bugs.chromium.org/p/chromium/issues/detail?id=924937#c13

Reference puppeteer#2548

Reference #2548

benbuzbee · 2019-11-07T01:49:50Z

@aslushnikov could be willing to take a stab at this but how long this issue has been neglected makes me nervous that there may be some hidden dangers.

What would you say are the major concerns?

The change seems something like

use target attached/detatched/destroyed events with type=iframe as a hint to the frame tree and update the frame manager accordingly
https://cs.chromium.org/chromium/src/content/browser/devtools/protocol/target_auto_attacher.cc?type=cs&sq=package:chromium&g=0&l=173
The frame needs its own CDPSession if created in this way instead of inheriting the parents so that it can use a separate sessionid, seems relatively straight-forward. Seems to be some finagling to do here so each instance ignores messages not meant for it
Commands that use the devtools Page domain that aren't already on the Frame class may need to be changed to send to all frame's sessions
This one may be sketch. Some commands will be fine, like captureScreenshot which can exist only being dispatched to the root frame, but others wont. It looks like Page.addScriptToEvaluateOnNewDocument doesn't filter to OOPIF so Page::exposeFunction() won't work for them. That said, this limitation seems like something that could be slowly addressed over time in the future and not having it but having most other things seems strictly better.

benkauffman · 2019-11-27T06:36:15Z

+1

Banou26 · 2019-11-27T15:33:33Z

Don't do that guys... It's useless, just use the reactions instead...
All it does is notify people watching this thread for nothing, no value added

…#6432) Debug message clarifying the problem like `Issue 1060080: Event Network.loadingFinished is not sent when a frame is loaded from another domain`: https://bugs.chromium.org/p/chromium/issues/detail?id=1060080). It can help users to identify problem with OOPIF easier without digging into the CDP protocol implementation like in the bug `1060080` mentioned above. To reproduce: 1. Run `DEBUG="puppeteer:frame" NODE_PATH=../ node examples/oopif.js`. 2. Verify the output contains the debug message: ` puppeteer:frame The frame '...' moved to another session. Out-of-proccess iframes (OOPIF) are not supported by Puppeteer yet. #2548 `

This pull request to adds better support for OOP iframes (see #2548) The current problem with OOP iframes is that they are moved to a different target. Because of this, the previous versions of Puppeteer pretty much ignored them. This change extends the FrameManager to already take OOP iframes into account and hides the fact that those frames are actually in different targets. Further work needs to be done to also make the NetworkManager aware of these and to make sure that settings like emulations etc. are also properly passed down to the new targets.

clouedoc · 2021-11-30T12:50:48Z

Should this issue be closed by #7556 ?

aslushnikov mentioned this issue May 15, 2018

iframe present in the DOM is not listed in page.frames() #1140

Closed

aslushnikov mentioned this issue May 17, 2018

page.frames() does not list chrome-extension:// frames on non-extension pages #2506

Closed

aslushnikov mentioned this issue May 31, 2018

waitForSelector not working for iframe, unable to find element in iframe #2602

Closed

aslushnikov mentioned this issue Jun 1, 2018

fix: disable OOPIF by default #2661

Merged

This was referenced Jun 20, 2018

Support Network requests in Workers #2781

Open

feat(worker): Allow Workers to emit their network events #2717

Closed

aslushnikov mentioned this issue Jul 4, 2018

.setCustomHeaders doesn't always work #2842

Closed

aslushnikov mentioned this issue Nov 14, 2018

Target: pass through "iframe" types #3518

Closed

aslushnikov added the chromium Issues with Puppeteer-Chromium label Dec 6, 2018

berstend mentioned this issue Jan 30, 2019

How to solve a CAPTCHA Challenge #473

Closed

Banou26 mentioned this issue Mar 1, 2019

v1 Banou26/EPK#1

Open

16 tasks

aslushnikov mentioned this issue Mar 15, 2019

Unable to get content of iframe inside shadow dom #4163

Closed

aslushnikov mentioned this issue Mar 30, 2019

Request interceptions cause web workers network requests to hang #4208

Closed

aslushnikov mentioned this issue Apr 12, 2019

Improve targeting devtools panel iframe created by an extension #4247

Closed

aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue May 29, 2019

test: add oopif tests

3156db1

Reference puppeteer#2548

aslushnikov mentioned this issue May 29, 2019

test: add oopif tests #4495

Merged

aslushnikov added a commit that referenced this issue May 29, 2019

test: add oopif tests (#4495)

015e330

Reference #2548

aslushnikov mentioned this issue Aug 14, 2019

feat(chromium): roll Chromium to r682225 #4844

Merged

hi-ogawa mentioned this issue Sep 26, 2019

Unable to access cross domain iframes when not headless #4960

Closed

tomholub mentioned this issue Mar 8, 2020

Add test for offline mode FlowCrypt/flowcrypt-browser#2630

Merged

ukrexpo mentioned this issue May 10, 2020

Puppeteer bot detection with out-of-process iframes by user-agent and screen size berstend/puppeteer-extra#196

Closed

tomholub mentioned this issue Sep 8, 2020

CORS issue when sending email on enterprise extension FlowCrypt/flowcrypt-browser#2934

Closed

5 tasks

patrickhulce mentioned this issue Feb 10, 2021

feat: expose other sessions from connection #6863

Merged

This was referenced Jul 1, 2021

JS is not executed #7346

Closed

Puppeteer page.evaluateOnNewDocument not running in iframe #7353

Closed

jschfflr mentioned this issue Sep 10, 2021

feat(oop iframes): integrate OOP iframes with the frame manager #7556

Merged

limonte mentioned this issue Nov 7, 2021

Upgrade to Puppeteer 11 FlowCrypt/flowcrypt-browser#4093

Merged

5 tasks

OrKoN closed this as completed Dec 2, 2021

sosnovsky mentioned this issue Feb 1, 2023

#4734 Use separate mock api for each test FlowCrypt/flowcrypt-browser#4928

Merged

5 tasks

infernalmaster mentioned this issue Jun 27, 2023

Not getting execution_id for frame rubycdp/ferrum#235

Closed

kaliiiiiiiiii mentioned this issue Oct 26, 2023

Capture tracing information for all iframes #8991

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support OOPIF #2548

Support OOPIF #2548

aslushnikov commented May 15, 2018

achingbrain commented May 15, 2018 •

edited

aslushnikov commented May 18, 2018

tomholub commented May 18, 2018

aslushnikov commented May 31, 2018

aslushnikov commented Jul 4, 2018

Swordyjohn commented Aug 16, 2018

aslushnikov commented Aug 17, 2018

Swordyjohn commented Aug 17, 2018 •

edited

tomholub commented Aug 19, 2018 via email

Banou26 commented Jan 16, 2019

defr0std commented Feb 26, 2019

benbuzbee commented Nov 7, 2019

benkauffman commented Nov 27, 2019

Banou26 commented Nov 27, 2019 •

edited

clouedoc commented Nov 30, 2021

Support OOPIF #2548

Support OOPIF #2548

Comments

aslushnikov commented May 15, 2018

achingbrain commented May 15, 2018 • edited

aslushnikov commented May 18, 2018

tomholub commented May 18, 2018

aslushnikov commented May 31, 2018

aslushnikov commented Jul 4, 2018

Swordyjohn commented Aug 16, 2018

aslushnikov commented Aug 17, 2018

Swordyjohn commented Aug 17, 2018 • edited

tomholub commented Aug 19, 2018 via email

Banou26 commented Jan 16, 2019

defr0std commented Feb 26, 2019

benbuzbee commented Nov 7, 2019

benkauffman commented Nov 27, 2019

Banou26 commented Nov 27, 2019 • edited

clouedoc commented Nov 30, 2021

achingbrain commented May 15, 2018 •

edited

Swordyjohn commented Aug 17, 2018 •

edited

Banou26 commented Nov 27, 2019 •

edited