-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser caching works with interception enabled, but the documentation says it shouldn't #2984
Comments
I can attest this! I can have my cake and eat it too, turning on caching and request interception, both of which saves me a ton of bandwidth for crawling. (Caching JS files and disabling images and tracking crap.) |
WOOOOOOOOW, just found this, since I want both caching and crap blocking.. I will do a test, and save me a day if it works. |
Unfortunately, on my test, it's not working, (cached is disabled when setRequestInterception (true) ) |
On 1.12.2 setting request interception enabled does indeed disable caching for me. (unfortunately I don't really want it to 😢 ) |
Would it be possible for #2905 be re-opened, so that we can have both caching and request interception? |
We're marking this issue as unconfirmed because it has not had recent activity and we weren't able to confirm it yet. It will be closed if no further activity occurs within the next 30 days. |
We are closing this issue. If the issue still persists in the latest version of Puppeteer, please reopen the issue and update the description. We will try our best to accomodate it! |
The documentation states:
However, this doesn't appear to actually be the case. I
await chromePage.setRequestInterception(true)
and log out cache activity:When I crawl the same page twice, my log reveals that cache is being used on the 2nd load for some resources (and for whom I
res.continue()
with no mutation), despite interception enabled:Am I mis-interpreting things, or should the documentation be updated to reflect that page caching will work w/ interception?
The text was updated successfully, but these errors were encountered: