Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target: pass through "iframe" types #3518

Closed
VikramTiwari opened this issue Nov 8, 2018 · 1 comment
Closed

Target: pass through "iframe" types #3518

VikramTiwari opened this issue Nov 8, 2018 · 1 comment

Comments

@VikramTiwari
Copy link
Contributor

Currently iframe target types are passed inside other type even when the actual information has the type 'iframe'. One sample is while opening anything on google drive, a target for OAuth can be seen with sample data in there:

targetId: "58521E586E76B7086CEA5F0A92B2378E", type: "iframe", title: "https://accounts.google.com/o/oauth2/postmessageR...

screen shot 2018-11-08 at 11 07 09 am

Any reason to not pass it as iframe type?

@aslushnikov
Copy link
Contributor

Any reason to not pass it as iframe type?

@VikramTiwari out-of-process iframes is a browser implementation detail and should be encapsulated inside the Puppeteer API. We don't want to expose any iframe targets; out-of-process iframes should be merged into the page frame tree.

Currently, we disable OOPIF as much as can, but certain origins are still pushed into OOPIF. There's an outstanding bug #2548 regarding this; please upvote to follow updates on that one.

Hope this helps,
Andrey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants