Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(firefox): support Page.setJavascriptEnabled #3970

Merged
merged 2 commits into from Feb 9, 2019
Merged

feat(firefox): support Page.setJavascriptEnabled #3970

merged 2 commits into from Feb 9, 2019

Conversation

aslushnikov
Copy link
Contributor

@aslushnikov aslushnikov commented Feb 9, 2019 •
edited

This patch implements:

  • Page.setJavascriptEnabled
  • Page.setCacheEnabled

@aslushnikov
feat(firefox): support Page.setJavascriptEnabled
3fa748a 
This patch implements:
- Page.setJavascriptEnabled - with test
- Page.setCacheEnabled - without a test since test relies on Network
JoelEinbinder
JoelEinbinder reviewed Feb 9, 2019
View reviewed changes
Copy link
Collaborator

@JoelEinbinder JoelEinbinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do a cache test without the network using the simpleserver?

@aslushnikov
Copy link
Contributor Author

Hmm let me try!

@aslushnikov
Copy link
Contributor Author

@JoelEinbinder worked out nicely!

@aslushnikov aslushnikov merged commit b82cc15 into puppeteer:master Feb 9, 2019
@aslushnikov aslushnikov deleted the disable-javascript branch February 9, 2019 04:57
This was referenced Feb 3, 2020
Open
Open
@snyk-bot snyk-bot mentioned this pull request Feb 22, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 10, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 31, 2020
Open
@snyk-bot snyk-bot mentioned this pull request May 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelEinbinder JoelEinbinder JoelEinbinder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aslushnikov @JoelEinbinder