New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add custom debugging port option #4993
feat: add custom debugging port option #4993
Conversation
5f6b741
to
b700ccf
Compare
b700ccf
to
8802d83
Compare
03a4ca1
to
d4b17bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tanhauhau Thanks for your contribution!
Could you update this patch to resolve the merge conflicts and make sure to add test coverage for this feature? chromiumonly.spec.ts
looks like a promising starting point but ideally, Firefox would also be covered.
lib/Launcher.js
Outdated
@@ -249,6 +250,8 @@ class Launcher { | |||
'--mute-audio' | |||
); | |||
} | |||
if (debuggingPort) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the documentation, you stated that passing 0
for the debuggingPort
will assign a random port but I think this if clause will prevent that from happening.
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
I found out that the only way to customise the debugging port for now is to pass in the
--remote-debugging-port
asargs
: