test: improve accessibility tests with autofocus #5116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashLadha
added a commit
to yashLadha/puppeteer
that referenced
this pull request
Nov 4, 2019
… tests This patch includes the changes from puppeteer#5116
|
Less flaky tests sounds great to me! Thanks for looking into this. |
mathiasbynens
approved these changes
Nov 27, 2019
This was referenced Feb 18, 2020
This was referenced Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to roll puppeteer-sharp to chromium r705776, I started getting many fails on these two tests.
I found that I'm getting the same running these tests on puppeteer locally. It seems that the inputs are not being autofocused sometimes, so the
focusedis false.I saw that puppeteer's PRs are being merged in green, but I also saw these errors on intermediate builds 1, 2, 3.
We could merge this PR, because accessibility tests are not about autofocusing with setContent, but we would also be hiding this issue on r705776.