Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Run unit tests against Firefox Nightly #5150

Closed
mjzffr opened this issue Nov 12, 2019 · 1 comment · Fixed by #5395
Closed

[CI] Run unit tests against Firefox Nightly #5150

mjzffr opened this issue Nov 12, 2019 · 1 comment · Fixed by #5395

Comments

@mjzffr
Copy link
Contributor

mjzffr commented Nov 12, 2019

(This depends on #5137)

Currently unit tests are run against the "Juggler" Firefox build together with the experimental puppeteer-firefox package. Let's also run the same unit tests against Firefox Nightly to test its remote agent, which is in active development.
@mjzffr mjzffr changed the title [CI] Run unit tests against Firefox [CI] Run unit tests against Firefox Nightly Nov 12, 2019
@mathiasbynens
Copy link
Member

Once this is done, we can start thinking about deprecating/removing the Juggler implementation in favor of the new approach in #5137.

@mjzffr mjzffr mentioned this issue Feb 6, 2020
Merged
mjzffr added a commit to mjzffr/puppeteer that referenced this issue Feb 6, 2020
@mjzffr
chore: Replace Juggler with Firefox Nightly in CI
7f2539c 
Fixes puppeteer#5150
mathiasbynens pushed a commit that referenced this issue Feb 20, 2020
@mjzffr
chore: Replace Juggler with Firefox Nightly in CI (#5395)
0b1a9ce 
Fixes #5150.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Replace Juggler with Firefox Nightly in CI mjzffr/puppeteer
2 participants
@mathiasbynens @mjzffr