Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Laucher, BrowserFetcher) Download appropriate Firefox version; determine executable path #5151

Closed
mjzffr opened this issue Nov 12, 2019 · 0 comments · Fixed by #5467
Closed

(Laucher, BrowserFetcher) Download appropriate Firefox version; determine executable path #5151

mjzffr opened this issue Nov 12, 2019 · 0 comments · Fixed by #5467

Comments

@mjzffr
Copy link
Contributor

mjzffr commented Nov 12, 2019

(This depends on #5137)

When users ask Puppeteer to run Firefox, they should have the option to make Puppeteer fetch an appropriate Firefox version.
@mjzffr mjzffr added the firefox label Dec 10, 2019
This was referenced Feb 4, 2020
Merged
Merged
@mjzffr mjzffr mentioned this issue Feb 28, 2020
Merged
mjzffr added a commit to mjzffr/puppeteer that referenced this issue Feb 28, 2020
@mjzffr
(feat) Add option to fetch Firefox Nightly
fb5e25c 
Add Firefox support to BrowserFetcher and the install script.
By default, the latest Firefox Nightly is downloaded
directly from archive.mozilla.org (dmg, tar.bz2 and zip)

This also required changes that impact `puppeteer.launch()`
and `puppeteer.executablePath()`

Fixes puppeteer#5151
hanselfmu pushed a commit that referenced this issue Mar 10, 2020
@mjzffr @mathiasbynens
(feat) Add option to fetch Firefox Nightly (#5467)
33f1967 
* (feat) Add option to fetch Firefox Nightly

Add Firefox support to BrowserFetcher and the install script.
By default, the latest Firefox Nightly is downloaded
directly from archive.mozilla.org (dmg, tar.bz2 and zip)

This also required changes that impact `puppeteer.launch()`
and `puppeteer.executablePath()`

Fixes #5151

* Update docs/api.md

Co-Authored-By: Mathias Bynens <mathias@qiwi.be>

* Clean up revision promise

* Improve error handling in revision check

* Remove matchAll

* Use explicit octal mode

* Update .gitignore

Co-authored-by: Mathias Bynens <mathias@qiwi.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(feat) Add option to fetch Firefox Nightly mjzffr/puppeteer
1 participant
@mjzffr