fix(types): publish protocol types to npm #5174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
9 tasks
CONTRIBUTING.md
Outdated
| @@ -252,8 +252,9 @@ Releasing to npm consists of the following phases: | |||
| 1. On your local machine, pull from [upstream](https://github.com/GoogleChrome/puppeteer) and make sure the last commit is the one just merged. | |||
| 2. Run `git status` and make sure there are no untracked files. | |||
| - **WHY**: this is to avoid adding unnecessary files to the npm package. | |||
| 3. Run [`npx pkgfiles`](https://www.npmjs.com/package/pkgfiles) to make sure you don't publish anything unnecessary. | |||
| 4. Run `npm publish`. This publishes the `puppeteer` package. | |||
| 3. Run `yarn` to make sure the latest `lib/protocol.d.ts` is generated. | |||
There was a problem hiding this comment.
Is there an easy way to do this that does not require installingyarn?
There was a problem hiding this comment.
This should work for npm install too. It's done in an install hook.
Could replace with npm run install / yarn install.
Co-Authored-By: Mathias Bynens <mathias@qiwi.be>
mathiasbynens
approved these changes
Nov 16, 2019
|
Thanks! |
This was referenced Feb 18, 2020
This was referenced Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #5168