fix(launcher): launcher.launch() should pass 'timeout' option #5180
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
ishmal
changed the title
|
@googlebot I fixed it. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
ishmal
changed the title
| const originalProto = Browser.prototype.waitForTarget; | ||
| let resTimeout = 0; | ||
| // function() because we want Browser's 'this' | ||
| Browser.prototype.waitForTarget = async function(predicate, options) { |
There was a problem hiding this comment.
The pattern we use to test timeout is setting the timeout to 1 and expecting to fail. See
|
Closing this in favor of #7596. |
Addresses #4782