Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(launcher): Set default Firefox prefs (#5149) #5195

Merged
merged 2 commits into from Nov 27, 2019

Conversation

mjzffr
Copy link
Contributor

@mjzffr mjzffr commented Nov 26, 2019

Add recommended automation preferences to profile
setup when launching Firefox. This profile can be overridden
by using the userDataDir launch option, or individual prefs
can be overwritten with the extraPrefsFirefox option.

The preferences have been reviewed by peers at Mozilla
over at https://bugzilla.mozilla.org/show_bug.cgi?id=1596888

Add recommended automation preferences to profile
setup when launching Firefox. This profile can be overridden
by using the `userDataDir` launch option, or individual prefs
can be overwritten with the `extraPrefsFirefox` option.

The preferences have been reviewed by peers at Mozilla
over at https://bugzilla.mozilla.org/show_bug.cgi?id=1596888
lib/Launcher.js Outdated Show resolved Hide resolved
Copy link
Member

@mathiasbynens mathiasbynens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. I fully defer to your expertise w.r.t. Firefox preferences.

Co-Authored-By: Mathias Bynens <mathias@qiwi.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants