Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated troubleshooting.md with recommendation of using args for heroku #5197

Merged
merged 2 commits into from Nov 27, 2019
Merged

Conversation

eko24ive
Copy link
Contributor

I decided to bring @ebidel advice in #758 issue to the troubleshooting.md file, since it isn't specified explicitly, only in mentioned issue and that "simple guide" below.

This argument stuff really helped me with getting puppeteer up and running on Heroku and I was frustrated when I realized that this solution is mentioned everywhere but in troubleshooting.md

P.S.
Really thankful for such an awesome tool. I ❤️it!

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@eko24ive
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Co-Authored-By: Mathias Bynens <mathias@qiwi.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants