Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api.md): Adding new example to page.$$eval #5200

Merged
merged 2 commits into from Jan 27, 2020

Conversation

ffeu
Copy link
Contributor

@ffeu ffeu commented Nov 27, 2019

IMHO it's unclear that the second parameter actually receives the array instead of being executed for each item. Adding this example to maybe make that clear.

IMHO it's unclear that the second parameter actually receives the array instead of being executed for each item. Adding this example to maybe make that clear.
@mathiasbynens
Copy link
Member

IMHO it's unclear that the second parameter actually receives the array instead of being executed for each item.

Arguably, the length example already makes that clear -- or at least, that the callback is being executed on something with a length property.

Adding this example to maybe make that clear.

The new example makes it clear that it's in fact a real array and not a NodeList, so I'll accept this PR for that reason :) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants