Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppeteer is rewriting core NodeJS method of https core module because of a lib used #5230

Closed
ouraios opened this issue Dec 6, 2019 · 0 comments · Fixed by #5243
Closed

Comments

@ouraios
Copy link

ouraios commented Dec 6, 2019

Puppeteer is using https-proxy-agent package which use agent-base which patch NodeJS https core module methods which prevent other packages to use the stream pipeline feature of NodeJS 10.

References :

I made a pull request to require https-proxy-agent only when needed so NodeJS core methods are not always patched #5224
Can you review and build a new puppeteer version to fix this awful issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant