Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade https-proxy-agent #5243

Merged
merged 1 commit into from Dec 11, 2019

Conversation

dguo
Copy link
Contributor

@dguo dguo commented Dec 11, 2019

https-proxy-agent requires agent-base, which currently monkey patches the core https Node module, causing problems in unrelated code. The latest version of https-proxy-agent uses the latest version of agent-base, which no longer does this monkey patching.

Fixes #5230.

#5224 is an alternative fix.

https-proxy-agent requires agent-base, which currently monkey patches
the core https Node module, causing problems in unrelated code. The
latest version of https-proxy-agent uses the latest version of
agent-base, which no longer does this monkey patching.
@ouraios
Copy link

ouraios commented Dec 11, 2019

@dguo I hope they will make a new release quickly so this issue can be solved using your PR or mine, i really need these fix to be able to use got

@dguo
Copy link
Contributor Author

dguo commented Dec 11, 2019

@ouraios, agreed. I'm also unable to use got v10 because of this issue.

@mathiasbynens mathiasbynens merged commit 80b5c44 into puppeteer:master Dec 11, 2019
@dguo dguo deleted the upgrade-https-proxy-agent branch December 11, 2019 14:41
@ouraios
Copy link

ouraios commented Dec 13, 2019

@mathiasbynens When can we expect the next release of puppeteer so we can have this fix to use NodeJS10 Stream pipeline safely ?

@mathiasbynens
Copy link
Member

"Soon".

For now you could try using the master branch directly (but keep in mind this is not officially supported):

npm install puppeteer/puppeteer#master

@elaijuh
Copy link

elaijuh commented Dec 16, 2019

What about puppeteer-core, can I use master branch before it got released?

@dguo
Copy link
Contributor Author

dguo commented Jan 28, 2020

This fix went out with the recent v2.1.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Puppeteer is rewriting core NodeJS method of https core module because of a lib used
5 participants