Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat(chromium): roll Chromium to r722269 #5289

Merged
merged 2 commits into from Jan 27, 2020
Merged

Conversation

mathiasbynens
Copy link
Member

@mathiasbynens mathiasbynens commented Jan 8, 2020

This corresponds to Chromium 80.0.3987.0.

This roll includes:

This roll includes:

- Implement support for the new ARIA `generic` role
  https://chromium-review.googlesource.com/c/chromium/src/+/1872305
- Expose button's children to accessibility tree
  https://chromium-review.googlesource.com/c/chromium/src/+/1845810
lib/Page.js Show resolved Hide resolved
Copy link
Collaborator

@hanselfmu hanselfmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; looks like a clean solution to me 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chromium Issues with Puppeteer-Chromium cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants