Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FAQ with an entry on cross-browser support #5360

Merged
merged 2 commits into from Jan 29, 2020

Conversation

TimvdLippe
Copy link
Contributor

No description provided.

README.md Outdated Show resolved Hide resolved
Co-Authored-By: Mathias Bynens <mathias@qiwi.be>
@mathiasbynens mathiasbynens merged commit 1a1ef83 into puppeteer:master Jan 29, 2020
@TimvdLippe TimvdLippe deleted the patch-1 branch January 31, 2020 21:19
Historically, Puppeteer supported Firefox indirectly through puppeteer-firefox, which relied on a custom, patched version of Firefox. This approach was also known as “Juggler”.
After discussions with Mozilla, we collectively concluded that relying on custom patches was infeasible.
Since then, we have been collaborating with Mozilla on supporting Puppeteer on “stock” Firefox.
From Puppeteer v2.1.0 onwards, as an experimental feature, you can specify [`puppeteer.launch({product: 'firefox'})`](https://github.com/puppeteer/puppeteer/blob/v2.1.0/docs/api.md#puppeteerlaunchoptions) to run your Puppeteer scripts in Firefox, without any additional custom patches.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't specify if consumers still need puppeteer-firefox or not.

puppeteer doesn't come with Firefox by default so setting it to product: 'firefox' is only the first step.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants