Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace Juggler with Firefox Nightly in CI #5395

Merged
merged 1 commit into from Feb 20, 2020

Conversation

mjzffr
Copy link
Contributor

@mjzffr mjzffr commented Feb 6, 2020

Fixes #5150

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Comment on lines +18 to +20
- 'if [ "$FIREFOX" = "true" ]; then pyenv shell 3.6; pip3 install --user mozdownload; fi'
- 'if [ "$FIREFOX" = "true" ]; then rm -rf $FIREFOX_HOME; mozdownload -t daily -d $FIREFOX_HOME/latest.tar.bz --log-level DEBUG; fi'
- 'if [ "$FIREFOX" = "true" ]; then cd $FIREFOX_HOME; tar -xvf latest.tar.bz; cd -; ls $FIREFOX_HOME/firefox/firefox; fi'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be able to remove this bit once #5151 is fixed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

Copy link
Member

@mathiasbynens mathiasbynens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to see this happening! Thanks for your work on this :)

@mathiasbynens
Copy link
Member

Let me know if there's a specific deprecation message/link you'd like to add to puppeteer-firefox.

Copy link
Collaborator

@hanselfmu hanselfmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well :)

@mjzffr
Copy link
Contributor Author

mjzffr commented Feb 7, 2020

Let me know if there's a specific deprecation message/link you'd like to add to puppeteer-firefox.

@mathiasbynens Will do. I hope to get to that soon.

@mjzffr
Copy link
Contributor Author

mjzffr commented Feb 7, 2020

I'll follow up in issue #5397

@whimboo
Copy link
Collaborator

whimboo commented Feb 14, 2020

@mjzffr, what is left to do here?

@mjzffr
Copy link
Contributor Author

mjzffr commented Feb 18, 2020

@mjzffr, what is left to do here?

@whimboo Nothing on my end, as I understand it. I assume @mathiasbynens et al will merge when they are ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Run unit tests against Firefox Nightly
5 participants