feat: id option for addScriptTag #5477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathiasbynens
force-pushed
the
main
branch
4 times, most recently
from
03a4ca1
to
d4b17bd
Compare
This comment has been minimized.
This comment has been minimized.
noam3127
force-pushed
the
script-tag-id
branch
from
cc291a6
to
ce40166
Compare
|
Fixed the conflicts. @jschfflr let me know if I can do anything else. Thanks. |
jschfflr
approved these changes
Sep 14, 2021
jschfflr
pushed a commit
to mushishi78/puppeteer
that referenced
this pull request
Sep 16, 2021
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5166