chore: Skip failing cookie tests in Firefox #5575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They fail because cookies in Firefox return a `sameSite` key which the tests don't expect. This is a solution that at least gets the Travis FF build (hopefully!) green again. Longer term it'd be great to allow the assertion to change based on the browser, rather than skip these tests entirely.
|
@mjzffr Could you PTAL? |
mjzffr
approved these changes
Apr 3, 2020
mathiasbynens
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They fail because cookies in Firefox return a
sameSitekey which thetests don't expect.
This is a solution that at least gets the Travis FF build (hopefully!)
green again. Longer term it'd be great to allow the assertion to change
based on the browser, rather than skip these tests entirely.