Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use expect for assertions #5581

Merged
merged 1 commit into from Apr 3, 2020
Merged

Conversation

jackfranklin
Copy link
Collaborator

Rather than use our own custom expect library, we can use expect from
npm 1, which has an API almost identical to the one Puppeteer has, but
with more options, better diffing and is used by many in the community
as it's the default assertions library that comes with Jest.

It's also thoroughly documented 2.

test/emulation.spec.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Rather than use our own custom expect library, we can use expect from
npm [1], which has an API almost identical to the one Puppeteer has, but
with more options, better diffing and is used by many in the community
as it's the default assertions library that comes with Jest.

It's also thoroughly documented [2].

[1]: https://www.npmjs.com/package/expect
[2]: https://jestjs.io/docs/en/expect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants