Trim CI down whilst we get it stable #5583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackfranklin
changed the title
jackfranklin
force-pushed
the
experimenting-with-travis
branch
from
1bc59f2
to
d5852d8
Compare
jackfranklin
force-pushed
the
experimenting-with-travis
branch
2 times, most recently
from
d5852d8
to
0f5509e
Compare
jackfranklin
changed the title
|
@mathiasbynens this is now passing on Travis. Please could you disable CirrusCI + Appveyor for now as discussed? Let's get CI stable on one browser and one OS and then we can iterate from there up to a full comprehensive suite where things are hopefully stable. |
jackfranklin
force-pushed
the
experimenting-with-travis
branch
from
c69be52
to
22f747d
Compare
jackfranklin
changed the title
Done. |
Our CI build has been incredibly flakey across all three of our current CIs: * Appveyor: Chromium + Windows * Travis: Firefox + Linux, Chromium + Linux * Cirrus: Chromium + Linux, Chromium + Mac Legitimate issues and errors have been missed because it's expected that the CI is red and therefore it's not seen as an issue when a PR's build fails. We should have a build that covers the full combo of browsers and operating systems but it's more important to have a consistent, reliable green build where failures are genuine. So this commit strips our CI back to Chromium on Linux on Travis, and nothing more. Once this is stable we will expand out into more operating systems and bring back Firefox, too.
jackfranklin
force-pushed
the
experimenting-with-travis
branch
from
22f747d
to
e4a5cde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI build has been incredibly flakey across all three of our current
CIs:
Legitimate issues and errors have been missed because it's expected that
the CI is red and therefore it's not seen as an issue when a PR's build
fails.
We should have a build that covers the full combo of browsers and
operating systems but it's more important to have a consistent, reliable
green build where failures are genuine. So this commit strips our CI
back to Chromium on Linux on Travis, and nothing more. Once this is
stable we will expand out into more operating systems and bring back
Firefox, too.