Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed .pdf part of api #5606

Merged
merged 1 commit into from Apr 8, 2020
Merged

changed .pdf part of api #5606

merged 1 commit into from Apr 8, 2020

Conversation

jshamg
Copy link
Contributor

@jshamg jshamg commented Apr 8, 2020

corrected example for future. old one doesn't work in our project anymore. thanks for this awesome tool btw!

corrected example for future. old one doesn't work in our project anymore.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@mathiasbynens mathiasbynens merged commit fefa8ca into puppeteer:master Apr 8, 2020
@mathiasbynens
Copy link
Member

@jshamg Could you please sign the CLA at https://cla.developers.google.com/? Thanks.

@jshamg
Copy link
Contributor Author

jshamg commented Apr 8, 2020

@googlebot I signed it!

@jshamg
Copy link
Contributor Author

jshamg commented Apr 8, 2020

@jshamg Could you please sign the CLA at https://cla.developers.google.com/? Thanks.

sold my soul ✌️ :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants