chore(deps): update extract-zip to version 2 #5610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extract-zip removed support for callbacks and instead uses promises. Moreover, it has TypeScript support which allows us to remove the @types/extract-zip package. This update allows downstream users to remove their installation of mkdirp, which uses a vulnerable version of minimist. For more info, see https://github.com/maxogden/extract-zip/releases/tag/v2.0.0
mathiasbynens
approved these changes
Apr 9, 2020
|
PTAL the CI errors. Looks like something is going wrong: |
jackfranklin
reviewed
Apr 9, 2020
| })); | ||
| async function extractZip(zipPath, folderPath) { | ||
| try { | ||
| extract(zipPath, {dir: folderPath}); |
There was a problem hiding this comment.
do you need an await here?
jackfranklin
reviewed
Apr 9, 2020
src/BrowserFetcher.js
Outdated
| })); | ||
| async function extractZip(zipPath, folderPath) { | ||
| try { | ||
| extract(zipPath, {dir: folderPath}); |
There was a problem hiding this comment.
same question here - await ?
|
Is there an approximate release date for the package containing this fix? Thanks! |
benlowry
added a commit
to userdashboard/dashboard
that referenced
this pull request
Apr 21, 2020
benlowry
added a commit
to userdashboard/maxmind-geoip
that referenced
this pull request
Apr 21, 2020
benlowry
added a commit
to userdashboard/example-web-app
that referenced
this pull request
Apr 21, 2020
benlowry
added a commit
to userdashboard/example-subscription-web-app
that referenced
this pull request
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extract-zip removed support for callbacks and instead uses promises.
Moreover, it has TypeScript support which allows us to remove the
@types/extract-zip package.
This update allows downstream users to remove their installation
of mkdirp, which uses a vulnerable version of minimist.
For more info, see https://github.com/maxogden/extract-zip/releases/tag/v2.0.0