Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mark version v3.0.0 #5642

Merged
merged 7 commits into from Apr 16, 2020
Merged

chore: mark version v3.0.0 #5642

merged 7 commits into from Apr 16, 2020

Conversation

hanselfmu
Copy link
Collaborator

@hanselfmu hanselfmu commented Apr 14, 2020

No description provided.

@hanselfmu
Copy link
Collaborator Author

@mathiasbynens My original PR was mysteriously deleted by Github after I have reset release-v3.0.0 branch with master, hence the new PR.

package.json Outdated
"description": "A high-level API to control headless Chrome over the DevTools Protocol",
"main": "index.js",
"repository": "github:puppeteer/puppeteer",
"engines": {
"node": ">=10.18.1"
},
"puppeteer": {
"chromium_revision": "722234",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do this change (+ any test expectation updates or other Puppeteer changes needed to support the new Chromium) in a separate CL.

The Chromium roll and the Puppeteer version bump should be separate commits.

package.json Outdated Show resolved Hide resolved
Copy link
Member

@mathiasbynens mathiasbynens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's get #5644 landed first.

README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants