chore: Log reminder about tsc if DocLint fails locally #5652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I lost some time debugging before realising that I needed to run tsc. I don't really want to put `npm run tsc` before this command else we'll run tsc multiple times on each CI build, so I think this message is suitable. Travis defines `process.env.TRAVIS` and if that exists we don't want to log this as on CI we're guaranteed to have an up to date `lib/` directory.
mathiasbynens
approved these changes
Apr 16, 2020
This was referenced May 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I lost some time debugging before realising that I needed to run tsc. I
don't really want to put
npm run tscbefore this command else we'llrun tsc multiple times on each CI build, so I think this message is
suitable.
Travis defines
process.env.TRAVISand if that exists we don't want tolog this as on CI we're guaranteed to have an up to date
lib/directory.