chore: manage published files via files option
#5659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than a denylist (`.npmignore`) we can instead use an allowlist via the `files` option in `package.json`. This makes it much harder to accidentally include files or folders in the build as you have to explicitly list the files that will be included. Fixes #5648.
jackfranklin
force-pushed
the
allow-list
branch
from
4cf8aa5
to
27fbbb2
Compare
mathiasbynens
approved these changes
Apr 17, 2020
mathiasbynens
requested changes
Apr 17, 2020
mathiasbynens
approved these changes
Apr 17, 2020
mathiasbynens
changed the title
files optionfiles option
jackfranklin
force-pushed
the
allow-list
branch
from
27fbbb2
to
873d686
Compare
mathiasbynens
approved these changes
Apr 17, 2020
This was referenced May 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5648 .
Before
After