Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Change the Alpine Docker example to use env instead of launch option #5666

Merged
merged 1 commit into from Apr 17, 2020

Conversation

neet
Copy link
Contributor

@neet neet commented Apr 17, 2020

This PR changes the documentation for the way to specify executablePath on Alpine Docker.

Formerly, the doc used options of puppeteer.launch, but since Puppeteer has an environment variable for it, I think it would be better to use it instead of specifying it every time.

I've already verified this can be built through the latest version of Docker. The Docker image can be found at DockerHub and the source code it at neetbox/pptr-alpine-docker.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@neet
Copy link
Contributor Author

neet commented Apr 17, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants