chore: migrate src/pipetransport to typescript
#5692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hit one bump in the fact that I want to share an interface across files. TypeScript only lets you import/export these if you're using ESM, not CommonJS. So the two options are: - Migrate to ESM on a per file basis as we do this migration. This won't affect the output as we output as CommonJS. - Create a global `types.d.ts` file that we'll use and then migrate to ESM after. Right now I've gone for the second option in order to not introduce more changes in one go. But if we end up finding we have lots of interfaces/types/etc that we want modules to expose, we might decide slowly introducing ESM might be a better way forwards.
jackfranklin
commented
Apr 20, 2020
mathiasbynens
approved these changes
Apr 20, 2020
|
@mathiasbynens 👍 It might be that we realise soon option 1 is better in which case let's just swap. One isn't more work than the other really so I'll just see how we go |
Co-Authored-By: Mathias Bynens <mathias@qiwi.be>
This was referenced May 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hit one bump in the fact that I want to share an interface across files.
TypeScript only lets you import/export these if you're using ESM, not
CommonJS. So the two options are:
affect the output as we output as CommonJS.
types.d.tsfile that we'll use and then migrate toESM after.
Right now I've gone for the second option in order to not introduce more
changes in one go. But if we end up finding we have lots of
interfaces/types/etc that we want modules to expose, we might decide
slowly introducing ESM might be a better way forwards.