chore: enforce spacing around braces #5700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathiasbynens
approved these changes
Apr 21, 2020
|
The Google JS style guide says "no spaces" but I'm fine with either option. Agreed that what matters is that we have consistency, not what the particular style is. |
Thinking about it, that's what Clang (and therefore DevTools) does, so I'll swap and do that one. |
The codebase was incredibly inconsistent with the use of spacing around
curly braces, e.g.:
```
// this?
const a = {b: 1}
// or?
const a = { b: 1 }
```
This extended into import statements also. Google's styleguide is no
spacing, so we're going with that.
jackfranklin
force-pushed
the
enforce-curly-spacing
branch
from
a96cc5b
to
5532978
Compare
mathiasbynens
changed the title
This was referenced May 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codebase was incredibly inconsistent with the use of spacing around
curly braces, e.g.:
This extended into import statements also. I don't have a strong
preference for each one but I feel strongly that we should be consistent
so this PR enforces the rule.