Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean travis.yml and docs #5716

Merged
merged 1 commit into from Apr 23, 2020
Merged

Clean travis.yml and docs #5716

merged 1 commit into from Apr 23, 2020

Conversation

munrocket
Copy link
Contributor

@munrocket munrocket commented Apr 22, 2020 •
edited

There was an outdated Travis initialization style, right now in Travis

  • linux os with xenial dist by default
  • node_modules cache by default
  • xvfb service will greatly improve configs

UPD:

  • added a simplified docs

@munrocket munrocket changed the title Clean travis.yml Clean travis.yml and docs Apr 22, 2020
@munrocket
Copy link
Contributor Author

travis.yml
docs

@jackfranklin
Copy link
Collaborator

@munrocket thanks for this! This looks good to me - let's see how the build goes and if it goes green I think we can ship. @mathiasbynens would you agree?

@munrocket
Copy link
Contributor Author

@jackfranklin fixed 🎉

@munrocket
Copy link
Contributor Author

Ok, this is ready for merge.

@jackfranklin jackfranklin merged commit ddb8ba1 into puppeteer:master Apr 23, 2020
@jackfranklin
Copy link
Collaborator

@munrocket thank you!

This was referenced May 3, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackfranklin jackfranklin jackfranklin approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@munrocket @jackfranklin @googlebot