Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make uploadFile throw for non-existent files #5733

Merged
merged 2 commits into from Apr 24, 2020
Merged

Conversation

paullewis
Copy link
Contributor

No description provided.

Copy link
Member

@mathiasbynens mathiasbynens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % question + nit

src/JSHandle.ts Outdated Show resolved Hide resolved
src/JSHandle.ts Show resolved Hide resolved
@mathiasbynens mathiasbynens changed the title JSHandle throws for non-existent files fix: make uploadFile throw for non-existent files Apr 24, 2020
@mathiasbynens mathiasbynens merged commit 79e82e5 into master Apr 24, 2020
@mathiasbynens mathiasbynens deleted the jshandle-throw branch April 24, 2020 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants