Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate src/LifecycleWatcher #5734

Merged
merged 1 commit into from Apr 27, 2020
Merged

Conversation

jackfranklin
Copy link
Collaborator

No description provided.

@jackfranklin jackfranklin added this to the TypeScript migration milestone Apr 24, 2020
_timeoutPromise: Promise<TimeoutError | null>;

_maximumTimer?: NodeJS.Timeout;
_hasSameDocumentNavigation?: boolean;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like how many of these there are but decided to do the minimal amount of work to migrate; we can refactor and tidy once in TS land. Also keeps the PRs less risky and easier to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants