Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the Firefox Nightly fetching code #5742

Closed
timvandermeij opened this issue Apr 26, 2020 · 1 comment · Fixed by #5864
Closed

Improve the Firefox Nightly fetching code #5742

timvandermeij opened this issue Apr 26, 2020 · 1 comment · Fixed by #5864

Comments

@timvandermeij
Copy link

I'm introducing Puppeteer for Mozilla's PDF.js project in mozilla/pdf.js#11807. While trying to figure out which version of Firefox was being downloaded, I noticed https://github.com/puppeteer/puppeteer/blame/master/install.js#L125-L151, but I think it can be simplified by simply quering the Firefox versions API instead. It can be found at https://product-details.mozilla.org/1.0/firefox_versions.json and provides you with a JSON response that is much easier to handle than the current solution where a regex is done over the response contents.

/cc @mjzffr since it was introduced in #5467
@timvandermeij timvandermeij mentioned this issue Apr 26, 2020
Merged
@mjzffr mjzffr added the firefox label May 7, 2020
@christian-bromann christian-bromann mentioned this issue May 13, 2020
Merged
christian-bromann added a commit to christian-bromann/puppeteer that referenced this issue May 13, 2020
@christian-bromann
chore: fetch Firefox from https://product-details.mozilla.org/1.0/fir…
862dc5c 
…efox_versions.json

fixes puppeteer#5742
mathiasbynens pushed a commit that referenced this issue May 13, 2020
@christian-bromann
chore: fetch Firefox from JSON source instead of RegExp (#5864)
b510c35 
Fetch Firefox from https://product-details.mozilla.org/1.0/firefox_versions.json.

Fixes #5742.
@timvandermeij
Copy link
Author

Thank you for improving this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fetch Firefox from json source instead of run a RegExp christian-bromann/puppeteer
2 participants
@timvandermeij @mjzffr